netftp Issue Tracker Rss Feed

Closed Unassigned: IBM MainFrame GetListing Fails [373]

jptrosclair — Thu, 23 May 2013 18:48:41 GMT

On IBM Mainframe getListing and GetNameListing fail.

ISSUE 1:
first the reason is the it tries to get the current directory but do to the naming conventions it fails here is how I fixed that for name listing:

String command;
if (String.IsNullOrWhiteSpace(path))
{
command = "NLST";
}
else
{
command = string.Format("NLST {0}", path.GetFtpPath());
}

using (FtpDataStream stream = OpenDataStream(command, 0))
{

also deleted where it sets path to current working directory if null or empty

ISSUE 2:
Another issue is the Parsers for getListing does not handle the response from the mainframe.
I've attached a Sample of the LIST response.

ISSUE 3:
on the getlisting if I do it on a empty mainframe directory it returns the 550 no data set error and in the library this throws.

Comments: IBM Main Frames, VAX, MODCOMPS and whatever else esoteric system are the exceptions here. I've built in support for adding your own parsers but there is no provision nor will there be for dealing with environments that don't support UNIX-style paths. If you can come up with a clean solution to the problem I'm all ears but I don't have one and I have no way to work on developing one as I don't have access to any of these kinds of systems and even if I did, from my end in terms of time and effort there is little value in adding support.

Commented Unassigned: IBM MainFrame GetListing Fails [373]

jptrosclair — Thu, 23 May 2013 18:25:17 GMT

On IBM Mainframe getListing and GetNameListing fail.

ISSUE 1:
first the reason is the it tries to get the current directory but do to the naming conventions it fails here is how I fixed that for name listing:

String command;
if (String.IsNullOrWhiteSpace(path))
{
command = "NLST";
}
else
{
command = string.Format("NLST {0}", path.GetFtpPath());
}

using (FtpDataStream stream = OpenDataStream(command, 0))
{

also deleted where it sets path to current working directory if null or empty

ISSUE 2:
Another issue is the Parsers for getListing does not handle the response from the mainframe.
I've attached a Sample of the LIST response.

ISSUE 3:
on the getlisting if I do it on a empty mainframe directory it returns the 550 no data set error and in the library this throws.

Comments: The 550 response is a permanent failure and System.Net.FtpClient handles it as such. It's not my fault if the server treats listing an empty directory as a permanent failure and I will not change the behavior on this end because it would break situations where there really was an error.

Commented Unassigned: IBM MainFrame GetListing Fails [373]

jptrosclair — Thu, 23 May 2013 18:24:41 GMT

On IBM Mainframe getListing and GetNameListing fail.

ISSUE 1:
first the reason is the it tries to get the current directory but do to the naming conventions it fails here is how I fixed that for name listing:

String command;
if (String.IsNullOrWhiteSpace(path))
{
command = "NLST";
}
else
{
command = string.Format("NLST {0}", path.GetFtpPath());
}

using (FtpDataStream stream = OpenDataStream(command, 0))
{

also deleted where it sets path to current working directory if null or empty

ISSUE 2:
Another issue is the Parsers for getListing does not handle the response from the mainframe.
I've attached a Sample of the LIST response.

ISSUE 3:
on the getlisting if I do it on a empty mainframe directory it returns the 550 no data set error and in the library this throws.

Comments: The 550 response is a permanent failure and System.Net.FtpClient handles it as such. It's not my fault if the server treats listing an empty directory as a permanent failure and I will change the behavior on this end because it would break situations where there really was an error.

Created Unassigned: IBM MainFrame GetListing Fails [373]

joporter_Ins — Thu, 23 May 2013 16:20:31 GMT

Closed Unassigned: error in FtpClient.cs::GetFileSize [372]

jptrosclair — Thu, 16 May 2013 15:05:34 GMT

If the SIZE command fails in the GetFileSize method it will return 0 and not -1 as the documentation says.
Tested version: 13.5.9.0
Comments: Fixed in latest revision

Commented Unassigned: error in FtpClient.cs::GetFileSize [372]

jptrosclair — Thu, 16 May 2013 14:33:30 GMT

If the SIZE command fails in the GetFileSize method it will return 0 and not -1 as the documentation says.
Tested version: 13.5.9.0
Comments: The latest [revision](https://netftp.codeplex.com/SourceControl/list/changesets) should address this problem.

Created Unassigned: error in FtpClient.cs::GetFileSize [372]

disinformation — Thu, 16 May 2013 12:44:15 GMT

If the SIZE command fails in the GetFileSize method it will return 0 and not -1 as the documentation says.
Tested version: 13.5.9.0

Closed Unassigned: Mocking FtpClient [371]

jptrosclair — Tue, 23 Apr 2013 13:31:20 GMT

Hi,

I use MoQ in my unit test, but i can't mock some FtpClient Methods.

System.NotSupportedException: Invalid setup on a non-virtual (overridable in VB) member.

Searching on the web it appears that i can only mock interfaces or virtual methods.

"In order to control the behavior of a mock object (in Moq, at least), you either need to mock an interface, or make sure that the behavior you're trying to control is marked virtual."

FtpClient implements no interfaces but IDisposable (not the method i want to mock) and many methods are not virtual.

Ex : public FtpListItem[] GetListing();

Is it possible to mark public method as virtual or define interface(s) ?
It would make TDD easier.
Comments: Latest revision contains contains interfaces.

Commented Unassigned: Mocking FtpClient [371]

jptrosclair — Tue, 23 Apr 2013 13:30:33 GMT

Commented Unassigned: Mocking FtpClient [371]

jptrosclair — Tue, 23 Apr 2013 01:40:03 GMT

Created Unassigned: Mocking FtpClient [371]

Jissai — Thu, 18 Apr 2013 08:22:18 GMT

Closed Issue: SFTP Connection Issue [370]

jptrosclair — Wed, 13 Mar 2013 20:08:40 GMT

Help! I am having a connection issue with sftp . I keep getting this error "Timed out trying to read data from the socket stream!"

Following is the code

var ftp = new System.Net.FtpClient.FtpClient

{

Host = "xxx.host.com",
Port = 1012,
Credentials = new NetworkCredential("user", "pwd")
,DataConnectionEncryption = true,
DataConnectionType = FtpDataConnectionType.AutoPassive
,EncryptionMode = FtpEncryptionMode.Explicit,

};

ftp.Connect(); // Error Here

FYI - I am not using any certificates

I successfully tried using filezilla and following is the log ( I masked the actual credentials and host name)
Status: Connecting to xxx.host.com:1012...
Response: fzSftp started
Command: open "user@ xxx.host.co" 1012
Command: Pass: **********
Status: Connected to xxx.host.co
Status: Retrieving directory listing...
Command: pwd
Response: Current directory is: "/"
Status: Directory listing successful

Comments: This code doesn't support SFTP, only FTP and FTPS.

Commented Issue: SFTP Connection Issue [370]

jptrosclair — Wed, 13 Mar 2013 20:08:16 GMT

Commented Issue: SFTP Connection Issue [370]

pollmaker — Wed, 13 Mar 2013 20:07:26 GMT

Created Issue: SFTP Connection Issue [370]

pollmaker — Wed, 13 Mar 2013 19:51:58 GMT

Closed Issue: invalid certificate [369]

jptrosclair — Mon, 04 Mar 2013 14:25:50 GMT

Hello,

I want to connect to my FTP server with explicit FTPS (server settings are set) but I get a invalid certificate error when I am trying to connect. This is my code:

http://img4.fotos-hochladen.net/uploads/ftpsyncerrorb3r7d4jcle.png

How do I fix this error?

Best regards,
chn
Comments: You're not holding it right

Commented Issue: invalid certificate [369]

jptrosclair — Mon, 04 Mar 2013 14:18:14 GMT

Commented Issue: invalid certificate [369]

jptrosclair — Mon, 04 Mar 2013 14:17:10 GMT

Created Issue: invalid certificate [369]

vrtz — Mon, 04 Mar 2013 08:55:25 GMT

Closed Issue: The FTPClient lacks a KeepAlive option. [368]

jptrosclair — Fri, 15 Feb 2013 15:18:36 GMT

For TCP Communication with an embedded host, i needed to set the KeepAlive Socket Option, which FTPClient lacks.

I have added this Option.
In File "FTPClient.cs" i added a property:

__// new property "KeepAlive" added
// Gerhard Biebl February 13, 2013
bool m_keepalive = false;
public bool KeepAlive
{
get
{
return m_keepalive;
}
set
{
m_keepalive = value;
}
}__

Furthermore, in File "FTPSocketStream.cs" i added the following to the "Connect" function:

m_socket = new Socket(addresses[i].AddressFamily, SocketType.Stream, ProtocolType.Tcp);

__if (m_keepalive == true)
{
m_socket.SetSocketOption(SocketOptionLevel.Socket,
SocketOptionName.KeepAlive,
true);
}____

Comments: Assuming new SocketKeepAlive property has addressed the issue. If it hasn't, open a new bug report.